Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] PartDesign: Temporarily Suppress / Hide Features - Add to UI #11212

Closed
2 tasks done
maxwxyz opened this issue Oct 27, 2023 · 10 comments · Fixed by #14112
Closed
2 tasks done

[Feature Request] PartDesign: Temporarily Suppress / Hide Features - Add to UI #11212

maxwxyz opened this issue Oct 27, 2023 · 10 comments · Fixed by #14112
Labels
Feature FR for improvements or new features UI/UX WB Part Design Related to the Part Design Workbench

Comments

@maxwxyz
Copy link
Collaborator

maxwxyz commented Oct 27, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Maybe this is only possible with a solution to the TNP but currently you can only view a current state of a body in Part Design WB by pressing the space bar on a feature, hiding all following features or set the tip to said feature.
In other software and in @realthunder link daily there are features to temporarily hide or suppress multiple features in any stage of the bodies feature tree:
grafik

Full version info

[code]
OS: Windows 11 build 22621
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.34789 (Git)
Build type: Release
Branch: main
Hash: 41503d63ebc3de96d156e6eb0cdb889ebb150bd4
Python 3.10.12, Qt 5.15.8, Coin 4.0.0, Vtk 9.2.5, OCC 7.6.3
Locale: German/Germany (de_DE)
Installed mods: 
  * 3DfindIT 1.2.0
  * 3D_Printing_Tools
  * BIM 2021.12.0
  * CfdOF 1.24.5
  * CurvedShapes 1.0.4
  * Curves 0.6.13
  * Defeaturing 1.2.1
  * fasteners 0.4.67
  * freecad.gears 1.0.0
  * freecad_metal_workbench
  * OpenDark 2023.10.20a
  * sheetmetal 0.3.1
  * Silk 0.1.5
[/code]

Subproject(s) affected?

PartDesign

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz luzpaz changed the title [Feature Request] Part Design: Temporarily Suppress / Hide Features [Feature Request] PartDesign: Temporarily Suppress / Hide Features Oct 28, 2023
@luzpaz luzpaz added WB Part Design Related to the Part Design Workbench Feature FR for improvements or new features labels Oct 28, 2023
@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Feb 17, 2024

@FlachyJoe can I close this as #12096 was merged?

@furgo16
Copy link
Contributor

furgo16 commented Feb 19, 2024

Do I understand it correctly that #12096 initially adds the feature, but there is a missing part of adding some sort of UI to more easily use it?

Right now, I can go to a feature's Data tab, select Show all and then set the Supressed property to false. Which works well (great work).

@FlachyJoe
Copy link
Contributor

@maxwxyz The feature is not fully usable yet because it's not implemented in Gui but feel free to close if you think it's good.

@furgo16

there is a missing part of adding some sort of UI to more easily use it

Yes, the feature is hidden until the TNP fix was fully merged due to the problems it can introduce in the model.
I had an idea to improve #12412, I'm working on it.

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Feb 20, 2024

Then I'll leave it open to implement the UI

@maxwxyz maxwxyz changed the title [Feature Request] PartDesign: Temporarily Suppress / Hide Features [Feature Request] PartDesign: Temporarily Suppress / Hide Features - Add to UI Feb 20, 2024
@maxwxyz maxwxyz added the UI/UX label Feb 20, 2024
@furgo16
Copy link
Contributor

furgo16 commented Feb 21, 2024

Thanks. Related: #12361

@maxwxyz

This comment was marked as outdated.

Sign in to view
@maxwxyz maxwxyz marked this as a duplicate of #12361 Feb 21, 2024
@maxwxyz maxwxyz closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Mar 9, 2024

Reopen to add it in the UI (menu + context menu) when TNP is fixed.

@maxwxyz maxwxyz reopened this Mar 9, 2024
@maxwxyz maxwxyz marked this as not a duplicate of #12361 Mar 9, 2024
@furgo16 furgo16 mentioned this issue Mar 13, 2024
Closed
2 tasks
@NomAnor
Copy link
Contributor

NomAnor commented May 17, 2024

Could this be ready for 1.0?

@FlachyJoe do you have code for the UI? If not I might to able to take a look.

What is needed?

  • Unhide the property
  • Add a main menu command to toggle the property
  • Add a tree context menu command to toggle the property

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented May 17, 2024

oh yes, this would be amazing in 1.0!

@FlachyJoe FlachyJoe mentioned this issue May 17, 2024
Merged
@FlachyJoe
Copy link
Contributor

  • Unhide the property
  • Add a main menu command to toggle the property
  • Add a tree context menu command to toggle the property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature FR for improvements or new features UI/UX WB Part Design Related to the Part Design Workbench
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PartDesign: hide Suppressed property with FC_USE_TNP_FIX flag FlachyJoe/FreeCAD
5 participants
@luzpaz @maxwxyz @NomAnor @FlachyJoe @furgo16