Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx-responsive fails on Angular 10 #151

Open
bjornharvold opened this issue Jul 4, 2020 · 4 comments
Open

ngx-responsive fails on Angular 10 #151

bjornharvold opened this issue Jul 4, 2020 · 4 comments

Comments

@bjornharvold
Copy link
Contributor

https://next.angular.io/guide/deprecations#modulewithproviders-type-without-a-generic

Compiling TypeScript sources through ngc
ERROR: node_modules/ngx-responsive/responsive.module.d.ts:15:49 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).

15     static forRoot(config?: IResponsiveConfig): ModuleWithProviders;
                                                   ~~~~~~~~~~~~~~~~~~~

An unhandled exception occurred: node_modules/ngx-responsive/responsive.module.d.ts:15:49 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).

15     static forRoot(config?: IResponsiveConfig): ModuleWithProviders;
@bjornharvold
Copy link
Contributor Author

PR here: #152

@stephenmaguireland
Copy link

When can we expect this fix to be merged and released? We need ngx-responsive in angular11

@marcinmilewicz
Copy link

Hi,
as it has been already merged, have you planned to release it in the near future?

@mburger81
Copy link

Hello we created a new nx workspace to keep some ngx libs up to date.

We added also the ngx-responsive lib, it should work out of the box you have only to change the import path.
We migrate it also to ng12, if you like please have a look

https://github.com/lanthings/ngx-components

npm i --save @lanthings/ngx-responsive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants