-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RabbitMqPortal needs to be revisited because it's not functional in the current state #3928
Comments
Agreed. It should work with an options class like HttpProxy. |
I wonder if GrpcPortal has the same issue? |
I don't think so. Or at least I did not create an issue during adding the nullable stuff :D |
Hello, i am not able to find any code related to this. May I know how I test it? |
It was originally something I created as a proof of concept, and so isn't well documented. I have now created a readme describing the way it should work. The |
The
RabbitMqPortal
implementation has two constructors.csla/Source/Csla.Channels.RabbitMq/RabbitMqPortal.cs
Line 33 in a60f4da
csla/Source/Csla.Channels.RabbitMq/RabbitMqPortal.cs
Line 58 in a60f4da
As you can see we can either set the necessary services or the data portal uri but NOT both. Hence I dare to say this implementation doesn't work as inteded.
So we should revisit this implementation to make it right.
Version and Platform
CSLA version: Current
The text was updated successfully, but these errors were encountered: