Flaky Test: "Request Queue SwitchChain -> WatchAsset should clear subsequent watchAsset after switching chain" #24596
Assignees
Labels
flaky tests
release-11.18.0
Issue or pull request that will be included in release 11.18.0
team-extension-platform
Comments
7 tasks
seaona
added a commit
that referenced
this issue
May 21, 2024
… clear subsequent watchAsset after switching chain` (#24674) ## **Description** This PR fixes the flaky test happening in Firefox browser. The problem is a race condition in mostly firefox browser where whenever we trigger 2 requests in a queue (Switch Network and Watch Asset), we were seeing the Watch Asset screen instead of the Switch Network screen. It used a delay to mitigate this, but it was still not 100% effective. Now the delay has been changed by a wait for condition. It also refactors the spec, in order to skip several initial steps for the test setup, by using fixtures: - we can skip the Connect to Dapp steps, and instead use the `.withPermissionControllerConnectedToTestDapp()` fixture - we can skip the Create Token Contract steps, and instead use the `smartContract` passed in fixtures [](https://codespaces.new/MetaMask/metamask-extension/pull/24674?quickstart=1) ## **Related issues** Fixes: #24596 ## **Manual testing steps** 1. Check ci 2. Run test multiple times locally `yarn test:e2e:single test/e2e/tests/request-queuing/switchChain-watchAsset.spec.js --browser=firefox --leave-running=true --retry-until-failure --retries=15` ## **Screenshots/Recordings** Artifacts and logs from ci failure   <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Harika Jetpoluru <153644847+hjetpoluru@users.noreply.github.com>
](https://codespaces.new/MetaMask/metamask-extension/pull/24674?quickstart=1){kind=link}
metamaskbot
added
the
release-11.18.0
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Failure:
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81128/workflows/1085f11b-e5d2-4b07-8417-12b03f96e723/jobs/2873806/tests
Error message
Screenshot
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: