fix(settings): fix #2012 exceptions thrown by non-unicode environment variables #2013
Conversation
… environment variables. scope: atuin-client changes: 1. add get_env_var in utils.rs 2. change load env in settings.rs
| #[test] | ||
| fn test_get_env_var_existing() { | ||
| // Set an environment variable for the purpose of this test. | ||
| env::set_var("TEST_ENV_VAR", "123"); |
There was a problem hiding this comment.
I suspect this may cause issues in tests, but let's see
|
I think the problem isn't fixed. I cherry-picked the fixes in this PR, but the behavior for https://github.com/mehcode/config-rs/blob/e3c1d0b452639478662a44f15ef6d5b6d969bf9b/src/env.rs#L323 |
I'm not very good at rustlang, so my pr may be problematic. Please feel free to drop this pr if there is a better solution. |
|
@akinomyoga is right, I read this too soon after waking up, sorry! 🤦♀️ We could make a PR to the crate, but it looks like it's currently looking for maintainers. I don't mind running against a fork for now |
|
See: #2016 |
fix #2012 an exception caused by the presence of non-unicode environment variables.
scope: atuin-client
changes:
Checks