feat(pipes-targets): add lambda function #30271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
repeat-contributor
WtfJoke
force-pushed
the
addLambdaPipeTarget
branch
3 times, most recently
from
23db285
to
3aa03cc
Compare
aws-cdk-automation
added
the
pr/needs-community-review
This was referenced May 27, 2024
RaphaelManke
reviewed
Jun 8, 2024
packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.lambda.handler/handler.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.lambda.handler/handler.ts
Outdated
Show resolved
Hide resolved
| const app = new App(); | ||
| const stack = new Stack(app, 'TestLambdaFunctionStack'); | ||
|
|
||
| const lambdaFunction = new lambda.Function(stack, 'MyLambda', { |
There was a problem hiding this comment.
You don't have to define a lambda. A string of an arn should be sufficient.
There was a problem hiding this comment.
Are you sure? Shouldnt be the lambda be available for import? Because for the LambdaFunction#grantPush you need a reference to a lambda.IFunction.
WtfJoke
force-pushed
the
addLambdaPipeTarget
branch
from
3aa03cc
to
125f4b6
Compare
WtfJoke
force-pushed
the
addLambdaPipeTarget
branch
from
125f4b6
to
d9e571b
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #30270.
Reason for this change
Lambda Function target is not supported yet by pipes-targets.
Description of changes
LambdaFunctionInvocationType.REQUEST_RESPONSEDescription of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license