-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --team to remaining fly commands #5215
Comments
Adds a `--team` flag to `unpause-pipeline` to allow unpausing pipelines from teams other than the current target. See concourse#5215. Fix formatting Remove FDescribe from test Add error handling test for unpause-pipeline --team
Adds a `--team` flag to `unpause-pipeline` to allow unpausing pipelines from teams other than the current target. See concourse#5215. Signed-off-by: Ozzy Walsh <git@ozzy.dev>
Adds a `--team` flag to `unpause-pipeline` to allow unpausing pipelines from teams other than the current target. See concourse#5215. Signed-off-by: Ozzy Walsh <git@ozzy.dev>
Adds a `--team` flag to `unpause-pipeline` to allow unpausing pipelines from teams other than the current target. See concourse#5215. Signed-off-by: Ozzy Walsh <git@ozzy.dev>
Hi @taylorsilva hope you had a good weekend! I would like to take one of these as a first contribution to concourse 😄 Picking one at random, I'll start on set-pipeline assuming its available? |
@jroden |
Hi @taylorsilva! Was hoping to pick up the Let me know if there are any issues! |
All yours! Thanks for contributing :) |
concourse#5215 Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
concourse#5215 Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
concourse#5215 Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
concourse#5215 Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
Allow for users to destroying pipelines for different teams without switching targets concourse#5215 Signed-off-by: Ka Hin Ng <kang@pivotal.io>
Allow for users to destroying pipelines for different teams without switching targets concourse#5215 Signed-off-by: Ka Hin Ng <kang@pivotal.io>
Allow for users to destroying pipelines for different teams without switching targets concourse#5215 Signed-off-by: Ka Hin Ng <kang@pivotal.io>
Allow for users to destroying pipelines for different teams without switching targets concourse#5215 Signed-off-by: Ka Hin Ng <kang@pivotal.io>
@taylorsilva is the |
@techgaun they're both yours! Thanks for the help :) |
Allows fly cli to get pipeline for different teams without having to switch targets concourse#5215 Signed-off-by: techgaun <coolsamar207@gmail.com>
Allows fly cli to get pipeline for different teams without having to switch targets concourse#5215 Signed-off-by: techgaun <coolsamar207@gmail.com>
Allows fly cli to expose pipeline for different team without having to switch targets concourse#5215 Signed-off-by: techgaun <coolsamar207@gmail.com>
Allows fly cli to expose pipeline for different team without having to switch targets #5215 Signed-off-by: techgaun <coolsamar207@gmail.com>
@taylorsilva looks like #5917 added team arg for |
Thanks for pointing that out! Updated the comment. Thanks again for your help! |
… to 6.7.x Allows fly cli to get pipeline for different teams without having to switch targets concourse#5215 Signed-off-by: techgaun <coolsamar207@gmail.com> Conflicts: fly/commands/get_pipeline.go
@taylorsilva is the destroy-pipeline available to pick? I would like to pick that if its free! |
@tech-geek29 all yours, thank you! |
@taylorsilva I think destroy-pipeline is already done & merged! I think it should be checked in above Goal. I can pick up checklist. I see that is free! |
It is, wonder when that got it 🤔 Feel free to do any of them and tag this issue in the PR |
@taylorsilva I do not have contributor access role. I am not able to add label to PR. What is the process for that? |
@tech-geek29 I just approved your request to join contributors in https://github.com/concourse/governance (welcome!) - can you try to add the label again? EDIT: you may have to approve an invitation, let us know if you didn't receive one |
Thanks very much @aoldershaw , I was able to attach labels. @taylorsilva @aoldershaw I have raised PR #7162. Can you please review and approve it? |
It'll be assigned to someone tomorrow during standup for review. Thanks for the PR! |
Awesome! Thanks @taylorsilva |
Hi @taylorsilva I would like to work on fly watch |
@dhantha sorry for the late reply, but go for it! |
@taylorsilva are some of these still up for grabs? (The ones that are unticked) Will take a look at getting to a couple of them :) |
@Caprowni the list is up to date, tackle any that you like :) |
List is still up to date |
Hey 👋 @taylorsilva I think there are a few that need ticked off the list that have already been done: check-resource |
List is now definitely up to date. Thanks @Caprowni! Sorted the list too so unfinished items are at the top. |
Hi @taylorsilva , have raised a PR #8940 for adding --team flag to rename-pipeline command. Could you please review it? |
Goal
Implement
--team
for remaining fly commands.fly/integration
tests should be updated. Cases should be added to theerror_handling
file as wellconcourse/fly/integration/error_handling_test.go
Line 92 in 5874834
hijackjobspause-jobtrigger-jobunpause-jobBackground
Follow-up story from #4196. You can look attrigger-job
for guidance on how to implement the flag.You can look at #7492 on how to implement the flag for the remaining commands.
The text was updated successfully, but these errors were encountered: