{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":455600,"defaultBranch":"master","name":"hhvm","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-01-02T01:17:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1708115215.0","currentOid":""},"activityList":{"items":[{"before":"dfb3de04ace13230daac9f1382a88571901f4405","after":"dbc2b190d003936bc9d2c1c1d7387b88f1fa83d3","ref":"refs/heads/master","pushedAt":"2024-06-13T01:34:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"require scope-guard functions to return precisely void\n\nSummary: Prevents mistakes with passed functions having a return value that is ignored. Allows a small simplification of the code.\n\nReviewed By: ot\n\nDifferential Revision: D58099033\n\nfbshipit-source-id: 0a02e563131fc055df746bc4ccf9f69dd051f407","shortMessageHtmlLink":"require scope-guard functions to return precisely void"}},{"before":"0d2c35fdcdcacacf65e46ddf3c64cd5053d735d7","after":"dfb3de04ace13230daac9f1382a88571901f4405","ref":"refs/heads/master","pushedAt":"2024-06-13T01:29:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove fizz::hpke::deserializePublicKey\n\nSummary: This function serves no purpose and is too HPKE specific.\n\nReviewed By: zalecodez\n\nDifferential Revision: D58425354\n\nfbshipit-source-id: 738d9c90d374203166fda3313cc07d2f2d453166","shortMessageHtmlLink":"Remove fizz::hpke::deserializePublicKey"}},{"before":"719fe209be28bc7969a1275de9fa4ba3d1a7ea19","after":"0d2c35fdcdcacacf65e46ddf3c64cd5053d735d7","ref":"refs/heads/master","pushedAt":"2024-06-13T01:02:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add diagnostic for using AsyncGenerator after exception or completion\n\nSummary: Unlike `Task`, `AsyncGenerator`'s awaiter does not destroy the coroutine promise upon receiving an exception or completion. This allows the caller to resume execution after the exception or return, violating the intended control flow and arbitrary preconditions of subsequent code that should have been unreachable. As a first step towards banning that behavior this diff adds a debug-mode diagnostic for awaiting a generator that has emitted an exception or completion.\n\nReviewed By: ispeters\n\nDifferential Revision: D58483579\n\nfbshipit-source-id: 8f9d5ec75b480be98288ede31cb1dd35a568cd23","shortMessageHtmlLink":"Add diagnostic for using AsyncGenerator after exception or completion"}},{"before":"0637d53742c407f27c883f6e30aab7bef642bdd2","after":"719fe209be28bc7969a1275de9fa4ba3d1a7ea19","ref":"refs/heads/master","pushedAt":"2024-06-13T00:52:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add documentation page for CurSe\n\nReviewed By: thedavekwon, vitaut\n\nDifferential Revision: D58475843\n\nfbshipit-source-id: b8569210b064e8f4ed82afa2856c4f98ab0fd1e6","shortMessageHtmlLink":"Add documentation page for CurSe"}},{"before":"cedb0ef941e870f1f12aa61e2540a4e80377e2f9","after":"0637d53742c407f27c883f6e30aab7bef642bdd2","ref":"refs/heads/master","pushedAt":"2024-06-13T00:04:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Rebuild fixtures\n\nSummary: rebuild fixture\n\nReviewed By: Mizuchi\n\nDifferential Revision: D58490842\n\nfbshipit-source-id: db75da0b877b9ac2b889e28ba4cc9727d169cc67","shortMessageHtmlLink":"Rebuild fixtures"}},{"before":"86c5bfef0c94d18ce4e79b021621e935b52070de","after":"cedb0ef941e870f1f12aa61e2540a4e80377e2f9","ref":"refs/heads/master","pushedAt":"2024-06-12T23:13:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"debugGetScmTree -> debugGetTree\n\nSummary: Implemented a new API debugGetTree to replace the original debugGetScmTree which has limited options available. The new api supports fetching the cache info of a tree from multiple layers, just like the other two edenfs debug commands: `blob` and `blobmeta`.\n\nReviewed By: kmancini\n\nDifferential Revision: D58057223\n\nfbshipit-source-id: cdf158ad24fd83cc0c6f4100d40322c541bc948e","shortMessageHtmlLink":"debugGetScmTree -&gt; debugGetTree"}},{"before":"a3103f5d7344700548602dc69d929d497522ad5f","after":"86c5bfef0c94d18ce4e79b021621e935b52070de","ref":"refs/heads/master","pushedAt":"2024-06-12T22:55:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"expose connId and security protocol to TServerObserver via ConnectionInfo\n\nSummary: TSIA, with this change, we will be able to expose server side counters for TLS12, Fizz, stopTLS, kTLS etc\n\nReviewed By: sazonovkirill\n\nDifferential Revision: D58368765\n\nfbshipit-source-id: ca5580edf30dba70a9b2382065df6c1fd5343f76","shortMessageHtmlLink":"expose connId and security protocol to TServerObserver via Connection…"}},{"before":"576f90aaa21db9c4bcb6bc312b701d099d2caf66","after":"a3103f5d7344700548602dc69d929d497522ad5f","ref":"refs/heads/master","pushedAt":"2024-06-12T22:18:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Added new method for digest in place.\n\nSummary: Add a new overload for merge allowing the caller to pass a scrap memory avoiding to touch the heap for each new merge.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D58347135\n\nfbshipit-source-id: fd4389c2c7a87537ef5ae0d707861a58fb691800","shortMessageHtmlLink":"Added new method for digest in place."}},{"before":"e505f3226876f15e65529a54510a2e2c1bc6161c","after":"576f90aaa21db9c4bcb6bc312b701d099d2caf66","ref":"refs/heads/master","pushedAt":"2024-06-12T22:12:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"pythonize services reflection\n\nSummary:\nTo reduce built binary size and get us closer to having services reflection work in auto-migrate mode, make the services_reflection into pure python.\n\nThis follows the same formula used for types reflection.\n\nReviewed By: yoney\n\nDifferential Revision: D58373403\n\nfbshipit-source-id: 901ea725246cbe6212cc6ce1a2de27af15f7be5a","shortMessageHtmlLink":"pythonize services reflection"}},{"before":"69865b22347a92104e0cac936b0093617119ccbb","after":"e505f3226876f15e65529a54510a2e2c1bc6161c","ref":"refs/heads/master","pushedAt":"2024-06-12T21:57:43.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Log header names and value length on HEADERS_TOO_LARGE\n\nSummary:\nWhen an HTTP/2 or 3 peer sends headers over the advertised limit, we trigger a compression error, but finding which header is excessively long is painful.  Log the header names and value lengths at VLOG(3), subject to a debug_ flag.  Note the dumpMessage(3) is now a DVLOG so only prints in debug builds.\n\nRefactor to use the same function for H2 and H3, and for both ingress and egress.\n\nExample string:\n\nURL(1), Host(15), http2-settings(32), User-Agent(13),\n\nReviewed By: kvtsoy\n\nDifferential Revision: D54223636\n\nfbshipit-source-id: 427848d3fab5f39f8577207183002efa108afd77","shortMessageHtmlLink":"Log header names and value length on HEADERS_TOO_LARGE"}},{"before":"3de1bdc6b9a1c5ac8a95ef874f7459bc75a30955","after":"69865b22347a92104e0cac936b0093617119ccbb","ref":"refs/heads/master","pushedAt":"2024-06-12T21:38:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deflaky large response test\n\nSummary: The later request still have chance to go timeout. Use a catch to deflaky the test.\n\nReviewed By: aristidisp, avalonalex\n\nDifferential Revision: D58476848\n\nfbshipit-source-id: ccabc6824e32518415dee9dd817065c943563ec8","shortMessageHtmlLink":"Deflaky large response test"}},{"before":"d27b064d61296e36675fff7c37830cac7d455cbf","after":"3de1bdc6b9a1c5ac8a95ef874f7459bc75a30955","ref":"refs/heads/master","pushedAt":"2024-06-12T21:09:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unnecessary getName override in ServiceInterceptorTest\n\nSummary: Not needed — we're using `NamedServiceInterceptor`.\n\nDifferential Revision: D58434612\n\nfbshipit-source-id: 43bf922ab35555a78460594509ff218d29e40b5e","shortMessageHtmlLink":"Remove unnecessary getName override in ServiceInterceptorTest"}},{"before":"adbf186f90eaa80ac7018d6009d5d8ac76373f6a","after":"d27b064d61296e36675fff7c37830cac7d455cbf","ref":"refs/heads/master","pushedAt":"2024-06-12T21:02:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"more realistic container usage benchmark\n\nSummary:\nThe struct container field access benchmark paints a skewed picture of thrift-py3 efficiency because it only tests sparse container access of a single element.\n\nA more typical use case involves accessing all elements of a container. This shows that the gap between `thrift-py3` and `thrift-python` isn't nearly as large as the old benchmark suggests.\n\nAfter\n```\n| Container Field Access (First/Uncached)   | list field iter   | list field idx   | set field iter   | set field lookup   | map field lookup one   | map field lookup all   | map struct list field   |\n|-------------------------------------------|-------------------|------------------|------------------|--------------------|------------------------|------------------------|-------------------------|\n| py-deprecated                             | 0.000787 ms       | 0.000091 ms      | 0.000895 ms      | 0.000097 ms        | 0.000099 ms            | 0.001779 ms            | 0.007431 ms             |\n| py3                                       | 0.001541 ms       | 0.000192 ms      | 0.001670 ms      | 0.000229 ms        | 0.000505 ms            | 0.008624 ms            | 0.041096 ms             |\n| python                                    | 0.002049 ms       | 0.001227 ms      | 0.002164 ms      | 0.001271 ms        | 0.002972 ms            | 0.010733 ms            | 0.050826 ms             |\n\n| Container Field Access (Repeated/Cached)   | list field iter   | list field idx   | set field iter   | set field lookup   | map field lookup one   | map field lookup all   | map struct list field   |\n|--------------------------------------------|-------------------|------------------|------------------|--------------------|------------------------|------------------------|-------------------------|\n| py-deprecated                              | 0.000785 ms       | 0.000086 ms      | 0.000869 ms      | 0.000096 ms        | 0.000100 ms            | 0.001788 ms            | 0.007585 ms             |\n| py3                                        | 0.001285 ms       | 0.000127 ms      | 0.001311 ms      | 0.000140 ms        | 0.000318 ms            | 0.008278 ms            | 0.041876 ms             |\n| python                                     | 0.001011 ms       | 0.000316 ms      | 0.001127 ms      | 0.000318 ms        | 0.000335 ms            | 0.007877 ms            | 0.014379 ms             |\n```\n\nBefore\n```\n| Container Field Access (First/Uncached)   | list field   | set field   | map field   | map struct list field   |\n|-------------------------------------------|--------------|-------------|-------------|-------------------------|\n| py-deprecated                             | 0.000094 ms  | 0.000100 ms | 0.000107 ms | 0.000137 ms             |\n| py3                                       | 0.000226 ms  | 0.000269 ms | 0.000612 ms | 0.000894 ms             |\n| python                                    | 0.001328 ms  | 0.001323 ms | 0.006680 ms | 0.027907 ms             |\n\n| Container Field Access (Repeated/Cached)   | list field   | set field   | map field   | map struct list field   |\n|--------------------------------------------|--------------|-------------|-------------|-------------------------|\n| py-deprecated                              | 0.000087 ms  | 0.000091 ms | 0.000105 ms | 0.000126 ms             |\n| py3                                        | 0.000132 ms  | 0.000161 ms | 0.000344 ms | 0.000481 ms             |\n| python                                     | 0.000327 ms  | 0.000345 ms | 0.000335 ms | 0.000631 ms             |\n```\n\nReviewed By: yoney, Filip-F\n\nDifferential Revision: D58474546\n\nfbshipit-source-id: cea743418f4d28649b1c41624457547adf4b7f40","shortMessageHtmlLink":"more realistic container usage benchmark"}},{"before":"8ca66011a7eba06008f553fbc52d1e16239fbe59","after":"adbf186f90eaa80ac7018d6009d5d8ac76373f6a","ref":"refs/heads/master","pushedAt":"2024-06-12T19:22:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix AssignPatch::toObject\n\nReviewed By: Mizuchi\n\nDifferential Revision: D58368272\n\nfbshipit-source-id: f4739986c35febc25430ebecf25be1809565c61f","shortMessageHtmlLink":"Fix AssignPatch::toObject"}},{"before":"7c204492a037936250e840727d12c1685fb317a9","after":"8ca66011a7eba06008f553fbc52d1e16239fbe59","ref":"refs/heads/master","pushedAt":"2024-06-12T19:02:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix Ord for field-defined `@rust.Type`\n\nSummary: fixing D58465969\n\nReviewed By: dtolnay\n\nDifferential Revision: D58475964\n\nfbshipit-source-id: f452d8db7b5ded4d4248c7053d0ce82b774ca425","shortMessageHtmlLink":"fix Ord for field-defined <code>@rust.Type</code>"}},{"before":"a2bee6e78eba07918b5f1411622b96eef10162b9","after":"7c204492a037936250e840727d12c1685fb317a9","ref":"refs/heads/master","pushedAt":"2024-06-12T18:55:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix //thrift/test/rust:rust_crate_map_test\n\nSummary:\nI broke this test in {D58398534}, as the contents of `fbcode//thrift/test/rust:fubar-rust-crate-map` has changed from:\n\n```lang=text\nbars best_crate //thrift/test/rust:fubar-rust\nfoos best_crate //thrift/test/rust:fubar-rust\n```\n\nto:\n\n```lang=text\nthrift/test/rust/bars.thrift best_crate //thrift/test/rust:fubar-rust\nthrift/test/rust/foos.thrift best_crate //thrift/test/rust:fubar-rust\n```\n\nReviewed By: capickett\n\nDifferential Revision: D58471742\n\nfbshipit-source-id: 43ce136b86f1723750b94e54090f32afba54fce3","shortMessageHtmlLink":"Fix //thrift/test/rust:rust_crate_map_test"}},{"before":"1c09f36d42c8cbcefd9cac71b773706a46c4cb24","after":"a2bee6e78eba07918b5f1411622b96eef10162b9","ref":"refs/heads/master","pushedAt":"2024-06-12T18:48:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"move slice-catching to make_exception_ptr_with\n\nSummary:\nThe `folly::exception_wrapper` constructors which take exception objects check that the static and dynamic types of the argument match to warn users when their code is likely mistaken.\n\nNow that `folly::make_exception_ptr_with` exists and since the mentioned constructors forward to it, it is a broader place for the facility.\n\nReviewed By: luciang\n\nDifferential Revision: D28250136\n\nfbshipit-source-id: 0732fb0ec5284a4bffee7ce9a8f2db7a0db2e687","shortMessageHtmlLink":"move slice-catching to make_exception_ptr_with"}},{"before":"1ca0329a76e8bb41fc51e064fd350a60f24bed08","after":"1c09f36d42c8cbcefd9cac71b773706a46c4cb24","ref":"refs/heads/master","pushedAt":"2024-06-12T18:35:30.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Switch to using folly::F14FastMap for query params\n\nSummary: In this diff, I'm switching the `HTTPQueryParamMap` alias to be a `folly::F14FastMap<std::string, std::string>` and am making auxiliary changes to Thrift definitions in order to facilitate the move to a `F14FastMap`.\n\nReviewed By: jbeshay\n\nDifferential Revision: D58200493\n\nfbshipit-source-id: 6deccfd0c7d36db79f861d040195df92649a03f3","shortMessageHtmlLink":"Switch to using folly::F14FastMap for query params"}},{"before":"d69d1945645aa2788bdb48a290afc8f0f6947901","after":"1ca0329a76e8bb41fc51e064fd350a60f24bed08","ref":"refs/heads/master","pushedAt":"2024-06-12T18:12:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Merge `typeinfo` and `mutable_typeinfo` mustache templates\n\nSummary: Introduce the `program:generate_mutable_types` flag and remove the `types/mutable_typeinfo.mustache` file. The `types/typeinfo.mustache` file now includes mutable typeinfos, and we select the appropriate one with the help of the `generate_mutable_types` flag.\n\nReviewed By: ahilger\n\nDifferential Revision: D58421057\n\nfbshipit-source-id: ecd30a5e1f7dea804fdb4f6e185c2110b2213ebb","shortMessageHtmlLink":"Merge <code>typeinfo</code> and <code>mutable_typeinfo</code> mustache templates"}},{"before":"be56f50a0cc0d808a18a0b046a790ac15a7606ab","after":"d69d1945645aa2788bdb48a290afc8f0f6947901","ref":"refs/heads/master","pushedAt":"2024-06-12T18:06:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Don't panic on tokio runtime shutdown\n\nSummary: Trying to address: https://fb.workplace.com/groups/learningrust/permalink/3721283454809179/\n\nReviewed By: emersonford\n\nDifferential Revision: D58306678\n\nfbshipit-source-id: 2b8961d1841fd50f727ff56f851da6f61876dfe2","shortMessageHtmlLink":"Don't panic on tokio runtime shutdown"}},{"before":"184305fcd6beb55a8754b2b3d21a5759bbf37b65","after":"be56f50a0cc0d808a18a0b046a790ac15a7606ab","ref":"refs/heads/master","pushedAt":"2024-06-12T17:00:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/390d5d94cfc856e7b72e842b0e0b330598a7b328\nhttps://github.com/facebook/fb303/commit/1b410a6099592b6accb1d2bdc5c0c183e4e1f85a\nhttps://github.com/facebook/fbthrift/commit/b07562ce9a683acd032c0e51d246ec89276d2f39\nhttps://github.com/facebook/folly/commit/c640d6cd31b9ce6077a1aa6ebde7304d8ecc6fe9\nhttps://github.com/facebook/mvfst/commit/39cfb960185b666f9e20383c319d6cdcdcb828ca\nhttps://github.com/facebook/proxygen/commit/a36073679c938aade198e92d108d4e7519dbcb38\nhttps://github.com/facebook/wangle/commit/2207d0a0764070472ac9e01eff6503edf6db659d\nhttps://github.com/facebookexperimental/edencommon/commit/f0aed68fbcce052f380d61c3acd6f81d800d1dbd\nhttps://github.com/facebookexperimental/rust-shed/commit/c096de640c100cbeadf903dad8c7ce5adbff23b2\nhttps://github.com/facebookincubator/fizz/commit/ee600b8dcdfb3b21a62be5257261448b9fd3aedd\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 159dc38c954716477edf8a0c0592e1d58dae8298","shortMessageHtmlLink":"Updating submodules"}},{"before":"df840cc4bcc7ea91069037857299da1b04195579","after":"184305fcd6beb55a8754b2b3d21a5759bbf37b65","ref":"refs/heads/master","pushedAt":"2024-06-12T15:54:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Include ServiceInterceptor name in exception returned to the user\n\nSummary:\nThe current implementation sends back the index (ordered) of the ServiceInterceptor as seen on the server side. This is next to useless on the client side.\n\nSince ServiceInterceptors now have names, we can have richer exception messages.\n\nReviewed By: vitaut\n\nDifferential Revision: D58434295\n\nfbshipit-source-id: 53f84ad4feb01d3c0c3a6723f72c093cf62e24a3","shortMessageHtmlLink":"Include ServiceInterceptor name in exception returned to the user"}},{"before":"d6e7cceaadb3b3a6254b9a995cc4750ca3d16a36","after":"df840cc4bcc7ea91069037857299da1b04195579","ref":"refs/heads/master","pushedAt":"2024-06-12T14:35:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add loose typing to debug_backtrace\n\nSummary:\nSorry if this is not valid or the right way to do this, but I figured it'd be easiest to just try it out and get feedback. To motivate this change, I recently foolishly assumed `args` would always be present in a frame, which broke a bunch of stuff (D57301367). I think the demographic of folks who typically work closely with stacks would be familiar with this fickleness of frame data, but alas, as a noob I didn't have this intuition. It would've been helpful to have some typing to guide me in the right direction of using `idx` or foregoing the usage of the data entirely.\n\nI based my typing off of [this docblock](https://www.internalfb.com/code/fbsource/[8eec5a24f012]/fbcode/hphp/runtime/ext/std/ext_std_errorfunc.php?lines=20-30) (which is almost certainly outdated, as seen by the omission of `metadata`) and [the code that generates the stack](https://fburl.com/code/0htc79f2). I opted for incredibly loose typing so as to not break anything. I know this is maybe *so* loose that it gives us almost no extra type safety, but I'm hoping that all the optional typing shows that nothing in the stack is guaranteed. If there is anything in the stack that you know is guaranteed, let me know and I can tighten it a bit.\n\nReviewed By: mheiber\n\nDifferential Revision: D57509960\n\nfbshipit-source-id: 0c0fca48082f580255a125daed78918862d0ee8b","shortMessageHtmlLink":"Add loose typing to debug_backtrace"}},{"before":"af4e3e455759283d3f90dd88f1256050baf299fe","after":"d6e7cceaadb3b3a6254b9a995cc4750ca3d16a36","ref":"refs/heads/master","pushedAt":"2024-06-12T14:11:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"Pass Hack type alias information through to textual\"\n\nSummary:\nOriginal commit changeset: 09f24945be4d\n\nOriginal Phabricator Diff: D58293959\n\nReviewed By: geralt-encore\n\nDifferential Revision: D58463615\n\nfbshipit-source-id: 0cf6cb2dcfd019bcdd8efcb475134f3123db996b","shortMessageHtmlLink":"Back out \"Pass Hack type alias information through to textual\""}},{"before":"87e60bdaacefd0ad8a6a14f6570c74a6ef05b0de","after":"af4e3e455759283d3f90dd88f1256050baf299fe","ref":"refs/heads/master","pushedAt":"2024-06-12T13:33:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove num_bytes\n\nSummary: remove num_bytes to fix lint in D58361818\n\nReviewed By: leoleovich\n\nDifferential Revision: D58407087\n\nfbshipit-source-id: 1b7d92ece2d4b2c928c4ac15cb27ea12b5280dec","shortMessageHtmlLink":"remove num_bytes"}},{"before":"b3c556af7eb23b2022ec1cb87179b484fca71872","after":"87e60bdaacefd0ad8a6a14f6570c74a6ef05b0de","ref":"refs/heads/master","pushedAt":"2024-06-12T13:00:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove Transport interface\n\nSummary: remove Transport interface\n\nReviewed By: leoleovich\n\nDifferential Revision: D58361854\n\nfbshipit-source-id: af16bef404f69c60418d81d9af35a506a2851865","shortMessageHtmlLink":"remove Transport interface"}},{"before":"baa64eb2f1eea2629a222287f6d318192d167a6c","after":"b3c556af7eb23b2022ec1cb87179b484fca71872","ref":"refs/heads/master","pushedAt":"2024-06-12T12:36:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"cleanup: local_config is not used in ClientConnect\n\nSummary: This also allows to remove the ref \"hack\" in clientCheck\n\nDifferential Revision: D58407351\n\nfbshipit-source-id: 5c3f68065270964f50cbe57d2cf1daaef55e3063","shortMessageHtmlLink":"cleanup: local_config is not used in ClientConnect"}},{"before":"f1a78bcf278f643a6a5bda06f9d269f35551e4cd","after":"baa64eb2f1eea2629a222287f6d318192d167a6c","ref":"refs/heads/master","pushedAt":"2024-06-12T12:30:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"IOBuf moveToFbString().toStdString() -> to<std::string>()\n\nSummary: Constructing an `fbstring` from an `IOBuf` and then converting that to `std::string` is inefficient: if the `IOBuf` is chained, that can end up copying the data twice. `to<std::string>()` does exactly one copy.\n\nReviewed By: afrind\n\nDifferential Revision: D58379775\n\nfbshipit-source-id: 8e1e00d4839d3b77854705c05250af14bbbcd6d9","shortMessageHtmlLink":"IOBuf moveToFbString().toStdString() -&gt; to&lt;std::string&gt;()"}},{"before":"f971a6634fa5375dc0a03ef6046fc63326e9ccf2","after":"f1a78bcf278f643a6a5bda06f9d269f35551e4cd","ref":"refs/heads/master","pushedAt":"2024-06-12T12:04:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Dynamic subtype of like-type shortcut in subtyping\n\nSummary: Revealed by subtype logging: for an assertion of the form `dynamic <: ~t` we unnecessarily chase down blind alleys. Instead we can spot the `dynamic` on the left and validate early.\n\nReviewed By: enetsee\n\nDifferential Revision: D58416971\n\nfbshipit-source-id: d5751bd2cc2631d1d815119c2094f453f0e3be94","shortMessageHtmlLink":"Dynamic subtype of like-type shortcut in subtyping"}},{"before":"f382bdc6716fcf50be29fa3735e2cf80b34ec25c","after":"f971a6634fa5375dc0a03ef6046fc63326e9ccf2","ref":"refs/heads/master","pushedAt":"2024-06-12T11:52:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert change that permitted extends clause in a public class to use internal types\n\nSummary:\nAfter discussion in the hack team we have decided to strengthen the checks on `extends` to prohibit public classes and interfaces extending internal types.\n\nSee this blog post explaining why they did the same in C#: https://ericlippert.com/2012/11/13/why-is-deriving-a-public-class-from-an-internal-class-illegal/\n\nReviewed By: dlreeves\n\nDifferential Revision: D58179675\n\nfbshipit-source-id: eafcf41ef11f4580147dba1ac2eccd490f7c50ac","shortMessageHtmlLink":"Revert change that permitted extends clause in a public class to use …"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEY-SySQA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/hhvm"}