-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord bot implementation #7134
Comments
i think the "developer account / register new application" part is pretty ... difficult to explain with reason - and quite some barrier to entry - at least for non-technical people. For the script - I'm not sure an external script pointing to the API provides much benefits other than complexity (having a separate script that's going to be installed, keeping that script running in parallel). You'll also in reality need one new application per bot (assume you run 10 bots - you'd need 10 applications). While not a huge problem - it's also not very convenient to setup - and I'm not sure how this would work if multiple bots would have to join the same server (which bot should respond to You should also keep in mind that a discord server is usually intended to be a community - so the base assumption is that there's multiple users in one server with access to this. as such - you'd then end up in a scenario where everyone has access to send commands to a bot. Assuming a full implementation, this would include also /forceentry /forceexit commands ... |
so does the webserver ... Personally, i think that a "per freqtrade" instance bot will be easier to digest / read - as you'll know "this comes from Bot XYZ" (similar to telegram) - but i guess that's personal preference. in reality, your "script" approach will clearly work (never said otherwise). but i don't see that way as being integrated into the freqtrade repository at the moment, not as script (scripts are usually high maintenance - or rather low maintenance until they break and noone notices - usually contain no tests - and therefore prone to break). Obviously that won't prevent this as as standalone / separate project providing the script. I could however imagine a As a side note - you'll also need to be careful with "bot is not up" - as that can block your whole setup if you're not careful (request timeouts ...) - but that's then details to figure out within the implementation. |
Sure, I wasn't intending this to be integrated at this stage as it's super early. Just wanted some initial feedback :) I suppose the good thing about the integrated approach is that once you've set it up, you don't need to adjust anything if you change/update the strategy etc. Hmm I didn't think of a separate command - I was thinking around a config-managed |
assuming you want it to be "multibot" based (Which i understood from the above) - then I'd assume you'd want to run it standalone (so it's detached from any other bots / bot tasks). my comment about "separate pypi package" was about the fact that you'd then avoid to install ta-lib, pandas, ... - which is not really necessary - at not using the approach when connecting to the api(s). |
I've been tinkering with a discord bot implementation and have got something working, but I am not sure if I'm going about it in the right/sensible way.
Currently someone that wants to use my code would have to:
pip3 install discord.py
Does this seem unfeasible for users? Is there a better way?
The text was updated successfully, but these errors were encountered: