Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General support for LR scheduler and optimizer #104

Open
qgallouedec opened this issue Apr 26, 2024 · 1 comment
Open

General support for LR scheduler and optimizer #104

qgallouedec opened this issue Apr 26, 2024 · 1 comment
Labels
✨ Enhancement New feature or request

Comments

@qgallouedec
Copy link
Member

          Okay, I see why you need these "hacks". Ideally what we want here is:
  1. General support for LR scheduling. Therefore the lr scheduler params should move out of the policy config.
  2. Policies have an optional get_optimizer_param_dicts. Might need more thinking through for the general design.
    Maybe we can keep these ideas out of this PR though. But what are your thoughts?

Originally posted by @alexander-soare in #99 (comment)

@alexander-soare
Copy link
Collaborator

Note that this was partially addressed by #121 where the LR scheduling was moved out of the policy config.

All that's left for this issue is to think about how to have the optimizer parameter selection not hard-coded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants