Add property outputTitle to CustomCommand #3579
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
LGTM, @stefanhaller. I've left a small suggestion comment, but the feature works as expected; nice work!
| return err | ||
| } | ||
| } else { | ||
| title = cmdStr |
There was a problem hiding this comment.
We could avoid having the else branch here by just assigning the cmdStr value to title as a default value and letting the conditional to override it if customCommand.OutputTitle != "". What do you think?
There was a problem hiding this comment.
Sure, why not. Changed in ba35802.
It can optionally be used to set the title of the panel that shows the output of a command (when showOutput is true). If left unset, the command string is used as the title.
stefanhaller
force-pushed
the
custom-command-output-title
branch
from
ba35802
to
22a38c9
Compare
Add property
outputTitleto CustomCommand. It can optionally be used to set the title of the panel that shows the output of a command (whenshowOutputis true). If left unset, the command string is used as the title.Closes #3576.
go generate ./...)docs/Config.md) have been updated if necessary