-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go vet lostcancel errors in legacy-cloud-providers files #109229
Comments
/sig cloud-provider |
@liggitt so is this should be resolved before v1.24? |
This has existed for 4 years, so it's not release blocking |
/triage accepted This is technically a bug, but since its been around for 4 years its not super high priority. |
#109184 (comment) |
/assign |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
looks like this is still an issue
|
/assign |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
want to contribute but can't get any idea about this issue can anyone give me a short overview of this issue? |
Hello, I'm new to k8s community and finding some good-first-issue to tackle. |
What happened?
We found go vet issues of
lostcancel
in #109184. (It seems that go vet checks are not running under/staging
dir.)We should fix them to ensure we don't introduce context leak as the message said.
What did you expect to happen?
These issues from go vet are fixed.
How can we reproduce it (as minimally and precisely as possible)?
Running go vet under
staging/src/k8s.io/legacy-cloud-providers/
Anything else we need to know?
No response
Kubernetes version
latest master
Cloud provider
OS version
Install tools
Container runtime (CRI) and version (if applicable)
Related plugins (CNI, CSI, ...) and versions (if applicable)
The text was updated successfully, but these errors were encountered: