You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to delete all the code related to GA in the repo including the CI job and any mentions of :googleanalytics in the codebase. We have a lot of special edge case stuff in the codebase for GA's hardcoded :metrics and :segments (which use string IDs instead of integers), we should remove that stuff from the MBQL schemas and all of the special case code. Examples of stuff to remove:
We should also double-check that things like the Database REST API endpoints don't blow up if we have a Database with a driver that no longer exists. The after-select method for :model/Database only calls metabase.driver.util/features if the driver is registered, so that should be good at least, but we should check other things as well just to be safe.
camsaul
changed the title
Remove Google Analytics driver and related special case stuff
Remove Google Analytics driver and related special case stuff. Ensure orphaned DBs do not blow up Metabase
May 16, 2024
@camsaul do you have an ETA for landing the remaining work here?
camsaul
changed the title
Remove Google Analytics driver and related special case stuff. Ensure orphaned DBs do not blow up Metabase
Remove Google Analytics driver and related special case stuff
May 30, 2024
We made the decision to deprecate it about a year ago because of #12905 (comment), now because it's blocking Metrics v2 we are finally going to drop it entirely. (We announced this in 47.) This needs to be done before we ship 50. See https://metaboat.slack.com/archives/C04DN5VRQM6/p1715888743074829 for more info.
We need to delete all the code related to GA in the repo including the CI job and any mentions of
:googleanalytics
in the codebase. We have a lot of special edge case stuff in the codebase for GA's hardcoded:metric
s and:segment
s (which use string IDs instead of integers), we should remove that stuff from the MBQL schemas and all of the special case code. Examples of stuff to remove:modules/drivers/googleanalytics
metabase/src/metabase/legacy_mbql/schema.cljc
Lines 987 to 996 in d142da9
metabase/deps.edn
Line 388 in 59e7b3d
metabase/src/metabase/xrays/automagic_dashboards/names.clj
Line 31 in cd007ba
Please be thorough and remove all the dead GA-related code!!! Please 🙇♂️
The text was updated successfully, but these errors were encountered: