-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize creating preview queries on the FE #42831
Comments
bshepherdson
added a commit
that referenced
this issue
May 17, 2024
bshepherdson
added a commit
that referenced
this issue
May 27, 2024
bshepherdson
added a commit
that referenced
this issue
May 27, 2024
bshepherdson
added a commit
that referenced
this issue
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the FE constructs preview queries by dropping clauses from the main query
metabase/frontend/src/metabase/query_builder/components/notebook/lib/steps.ts
Line 313 in 76a473a
We need a performant way to construct preview queries. It should be straightforward to add a MBQL lib function for this:
The function should return a query with all the stages after
stageIndex
dropped, and all the clauses afterclauseType
dropped. AlsoclauseIndex
can be optionally provided; in this case only clauses of this type in the range[0, clauseIndex]
should remain.Examples:
The text was updated successfully, but these errors were encountered: