Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@effect github ? #6003

Open
jonlepage opened this issue May 10, 2024 · 4 comments
Open

@effect github ? #6003

jonlepage opened this issue May 10, 2024 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@jonlepage
Copy link

can you tell me why when i mouse hover a jsdoc @effect vscode show me link to this guy profile ?!
https://github.com/effect

image

  • VS Code Version:
Version : 1.89.1 (user setup)
Validation : dc96b837cf6bb4af9cd736aa3af08cf8279f7685
Date : 2024-05-07T05:13:33.891Z
Electron : 28.2.8
ElectronBuildId : 27744544
Chromium : 120.0.6099.291
Node.js : 18.18.2
V8 : 12.0.267.19-electron.0
Système d’exploitation : Windows_NT x64 10.0.19045

Steps to Reproduce:

mouse hover @effect

export enum _ {

	/**
	 * @effect
	 */
}
@mjbvz mjbvz assigned alexr00 and unassigned mjbvz May 14, 2024
@alexr00 alexr00 transferred this issue from microsoft/vscode May 15, 2024
@alexr00 alexr00 added this to the May 2024 milestone May 15, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label May 15, 2024
@alexr00
Copy link
Member

alexr00 commented May 29, 2024

@jonlepage what library are you using where @effect is a jsdoc tag?

@alexr00 alexr00 modified the milestones: May 2024, Backlog May 29, 2024
@jonlepage
Copy link
Author

@jonlepage what library are you using where @effect is a jsdoc tag?

is my custom game engine.
I use some of unused JSDoc tags to document some of aspects of my architecture, but I just realized that all unused tags point to GitHub! profiles !
this is weird !

@alexr00
Copy link
Member

alexr00 commented May 30, 2024

For common @ tags in jsdoc we have them excluded from the GitHub user hovers, but since it's custom we don't know which @ tags are part of your jsdoc and which ones are supposed to reference users. I guess we need to have a setting so that you can choose which ones you want to exclude.

@alexr00 alexr00 added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels May 30, 2024
@jonlepage
Copy link
Author

For common @ tags in jsdoc we have them excluded from the GitHub user hovers, but since it's custom we don't know which @ tags are part of your jsdoc and which ones are supposed to reference users. I guess we need to have a setting so that you can choose which ones you want to exclude.

Okay, thank you for taking the time to explain that to me.
Having a setting to disable this feature seems like a reasonable solution for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants