Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌[FEATURE]: More precise definition of action naming in docs #1629

Open
PendelinP opened this issue Jun 24, 2020 · 3 comments
Open

馃殌[FEATURE]: More precise definition of action naming in docs #1629

PendelinP opened this issue Jun 24, 2020 · 3 comments

Comments

@PendelinP
Copy link

Description

Currently the word Action is used for two things:

  1. The action class itself containing the action data (https://www.ngxs.io/concepts/actions)
  2. The implementation of the state change within the store class (https://www.ngxs.io/concepts/state#defining-actions)

This might lead to confusing discussions. Wouldn't it be nice to "rename/specify" the implementation to someting like Action Executors (since the term Action Handler is already used here: https://www.ngxs.io/advanced/action-handlers). NgRx calls such action handlers reducers which would fit as well.

What do you think? I'd love to support the project by updating the docs :)

@splincode
Copy link
Member

@PendelinP create pull request please as you expected action naming in docs and we help you

@PendelinP
Copy link
Author

Wow - that was fast :) Thanks a lot - will do ;)

@markwhitfeld
Copy link
Member

See related discussions in previous issues here:
#1438
#125

There isn't any really decent proposal for a better name at the moment.
I am open to hearing proposals (see existing ideas in the issues listed above).

PS. the use of "Action Handlers" in the docs to refer to what I call "Action Observers" (where you observe the action stream) has bugged me. It forces me to call the ones in the States "Action Hooks".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants