Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it correct for the FormGroup sub label colour to be determined by the intent? #6808

Closed
berryde opened this issue May 18, 2024 · 0 comments · Fixed by #6811
Closed

Is it correct for the FormGroup sub label colour to be determined by the intent? #6808

berryde opened this issue May 18, 2024 · 0 comments · Fixed by #6811

Comments

@berryde
Copy link
Contributor

berryde commented May 18, 2024

Environment

  • Package version(s): @blueprintjs/core 5.10.3
  • Operating System: Windows
  • Browser name and version: Google Chrome 125.0.6422.60

Code Sandbox

Link to a minimal repro: https://blueprintjs.com/docs/#core/components/form-group

Steps to reproduce

  1. Enable "Show sub label"
  2. Set the intent to e.g. "Danger"

Actual behavior

The sub label inherits the colour of the intent.

image

Expected behavior

The sub label, like the label should remain unchanged when an intent is supplied.

image

Unlike the helper text, which I understand should be used to display information based on the supplied value (such as "This username is already taken"), the sub label is not contextual and should not be re-coloured based on the intent of the FormGroup.

Possible solution

Do not colour the sub label based on the intent, and instead maintain a constant colour as is done for the label. I think that this change should be made because the sub label should be used to provide further information about the label, and the label does not change colour based on the intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant