Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix default value of GetDefaultCollationForUTF8MB4 of StaticExprContext #53391

Merged
merged 1 commit into from
May 20, 2024
Merged

expression: fix default value of GetDefaultCollationForUTF8MB4 of StaticExprContext #53391

merged 1 commit into from
May 20, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #53390

What changed and how does it work?

fix default value of GetDefaultCollationForUTF8MB4 of StaticExprContext

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2024
@tiprow tiprow
Copy link

tiprow bot commented May 20, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

YangKeao
YangKeao approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

windtalker
windtalker approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-20 07:51:21.817176279 +0000 UTC m=+2071635.574311846: ☑️ agreed by YangKeao.
  • 2024-05-20 07:51:58.538017482 +0000 UTC m=+2071672.295153055: ☑️ agreed by windtalker.

@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6305%. Comparing base (397a460) to head (310a3b3).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53391        +/-   ##
================================================
+ Coverage   72.5545%   74.6305%   +2.0760%     
================================================
  Files          1505       1505                
  Lines        429830     429985       +155     
================================================
+ Hits         311861     320900      +9039     
+ Misses        98694      89195      -9499     
- Partials      19275      19890       +615
Flag Coverage Δ
integration 49.4041% <100.0000%> (?)
unit 71.3440% <100.0000%> (-0.1024%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4028% <ø> (+8.9988%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 044f113 into pingcap:master May 20, 2024
23 checks passed
@lcwangchao lcwangchao deleted the fix_def_utf8collation branch May 20, 2024 14:23
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 20, 2024
@lcwangchao @terry1purcell
expression: fix default value of GetDefaultCollationForUTF8MB4 of `…
9bd7633 
…StaticExprContext` (pingcap#53391)

close pingcap#53390
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
@lcwangchao @RidRisR
expression: fix default value of GetDefaultCollationForUTF8MB4 of `…
4a99a42 
…StaticExprContext` (pingcap#53391)

close pingcap#53390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The default value of GetDefaultCollationForUTF8MB4 is not righ StaticExprContext
3 participants
@lcwangchao @windtalker @YangKeao