-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Make naming conventions rule skip unnamed variables #5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
jsotuyod
reviewed
May 14, 2024
...java/src/main/java/net/sourceforge/pmd/lang/java/symbols/table/internal/SymTableFactory.java
Outdated
Show resolved
Hide resolved
We should probably add a parsing test for pre-Java9 to ensure that Apart from that this looks great to merge, thanks! |
I'll add a test for that and merge it afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
I think the best solution here is not to allow
_
through the regexes as suggested in #4954 but rather to always ignore these variables. That's because I don't think the rule should ever be used to disallow unnamed variables. We would otherwise be restricting a useful language feature, and anyone changing the convention would need to explicitly takes care of special casing this identifier.Related issues
Ready?
./mvnw clean verify
passes (checked automatically by github actions)