Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage folder seems like it is sometimes not needed #51835

Closed
jeromedalbert opened this issue May 15, 2024 · 0 comments · Fixed by #51837
Closed

Storage folder seems like it is sometimes not needed #51835

jeromedalbert opened this issue May 15, 2024 · 0 comments · Fixed by #51837

Comments

@jeromedalbert
Copy link
Contributor

jeromedalbert commented May 15, 2024

Steps to reproduce

rails new myapp --skip-active-storage -d postgresql
ls

Expected behavior

There should be no storage folder.

Actual behavior

There is a storage folder.

System configuration

Rails version: 7.1.3.2

Ruby version: 3.3.1

Comments

I may be wrong but it seems like the storage folder is only needed for sqlite or Active Storage. Based on some of the Rails code here and here, it seems that when using a different database and the --skip-active-storage option, this folder isn't really useful. So maybe it should not be created by rails new.

Related: #51836
Potential fix: #51837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants