Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): added missing CommandList to combobox docs #3431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

neighborhood999
Copy link

@neighborhood999 neighborhood999 commented Apr 9, 2024

I think this PR can fixed: #3732, #3707, #809, #3012, #3637

Copy link

vercel bot commented Apr 9, 2024

@neighborhood999 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@ezeparziale
Copy link

I think that this need cmdk == 1.0.0

https://github.com/pacocoursey/cmdk/releases/tag/v1.0.0

@mpourismaiel
Copy link

Please replace data-[disabled] classes with aria-disabled for CommandPrimitive.Item as well. Other changes may be required per cmdk@v1 but that was the only issue I encountered.

@neighborhood999
Copy link
Author

Hi @ezeparziale and @mpourismaiel,

Thanks for reminding me, I applied your guys' suggestions.

@braden-w
Copy link

Stumbled upon the same issue and fix independently today, was crashing local development. Good to see a fix and hope it gets merged soon 👍

Copy link

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this. Looks good to me! ✔︎

@neighborhood999
Copy link
Author

Hey @shadcn, can you help to verify this PR : )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: The source code for the combobox form has a bug
5 participants