Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Yarn version #1108

Open
eric-burel opened this issue Jun 14, 2019 · 2 comments
Open

Document Yarn version #1108

eric-burel opened this issue Jun 14, 2019 · 2 comments

Comments

@eric-burel
Copy link
Contributor

eric-burel commented Jun 14, 2019

Related to #938 , we should update this part of the doc:

  1. Install the dependencies. Make sure that you use Yarn 1.0.0 or higher.
yarn

You can use NPM instead of Yarn to handle the starter kit dependencies and to run scripts. Throughout the Apollo
Universal Starter Kit documentation, we'll always use Yarn.

Yarn 1.12.x won't work, so we could suggest to avoid it. Also I am not sure about saying you can use NPM instead of yarn.
It worked for adding packages in specific app with npm install in packages/server or packages/client, however to upgrade a package (eg extract-files to version 5.0.0 for Storybook to work), I've had to run yarn upgrade from the root of the project, otherwise it wouldn't update the yarn.lock.

Basically that's a tripping point for people not used to yarn especially in a boilerplate with multiple environment, so I think it's worth it to give a bit more details about yarn usage in the Readme or in other part of the doc.

@larixer
Copy link
Member

larixer commented Jun 14, 2019

@eric-burel Thank you Eric, good point! Yes, we no longer support npm, because we use Yarn workspaces

@eric-burel
Copy link
Contributor Author

Also some issue I have is that core-js gets installed and added to the lock with version 1.0.0 whenever I use yarn add in packages/server. There might be one package with bad dependencies but I can't tell which. I have to remove it from the yarn.lock afterward and rerun yarn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants