New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected use case not caught by edit distance algorithm #48

Open

Sudx-old-gamer-new-coder opened this issue Jan 25, 2018 · 2 comments

Assignees

Labels

bug Fixed. Waiting for Test P1 - High Priority

Contributor

Sudx-old-gamer-new-coder commented Jan 25, 2018 •

edited

The following use case was not caught by surf in edit distance 2.

BIREN DUTTA -> BI DU REN TA
BIREN DATTA -> BI DATA REN

Expected: should show up in edit distance 2
Actual: doesn't show up

Tripura worksheet attached.
tripura_ws.csv.zip
attached.

Sudx-old-gamer-new-coder added bug P1 - High Priority labels

Sudx-old-gamer-new-coder assigned hangal

Contributor Author

Sudx-old-gamer-new-coder commented Jan 25, 2018

Another test case:

DASARATHA DEB -> ARTA DAS DEB
DASHARATH DEB -> DAS DEB RT

Collaborator

hangal commented Feb 12, 2018

I find it works on a sample test case with these lines:

--
"Cand1","Candidate_Type","District_Name","comments","Position","Sex","Constituency_No","poll_no","Assembly_No","Constituency_Name","DelimID","Party","Year","Sub_Region","State_Name","Votes1","ID","Age"
"BIREN DUTTA","","","","1","M","35","0","9","GANGATH","3","BJP","1998","","Himachal_Pradesh","18771","4200","1"
"BIREN DATTA","","","","1","M","35","0","9","GANGATH","3","BJP","1998","","Himachal_Pradesh","18771","4209","2"
"DASARATHA DEB","GEN","MANDI","","6","M","33","0","12","MANDI","4","CPI","2012","BEAS RIVER REGION","Himachal_Pradesh","1468","3837","3"
"DASHARATH DEB","GEN","MANDI","","6","M","33","0","12","MANDI","4","CPI","2012","BEAS RIVER REGION","Himachal_Pradesh","1468","3839","4"

hangal pushed a commit that referenced this issue


          fixes for #48

399ccda

hangal added the Fixed. Waiting for Test label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment