Proper management of datasets

[hangal]

User imported a dataset into Surf. Forgot to check "has headers".

Now the user is stuck, even if they upload the file again, they will only see col1, col2, ... as the column names.

1. On upload of the same file, the user should be presented with a warning, and if confirmed, the file should get overwritten.
2. Need a way to delete datasets.

[checker5965]

1. is resolved in commit 8ec852b plz review.

[checker5965]

@hangal I have implemented a partial fix for 2. in commit 2ffb375
There is a weird bug though. If I upload multiple files one after the other, I am able to delete only one of them.

A few examples- [U = upload, D= Delete]

U file 1
D file 1 (success)
U file 2
D file 2 (success)
U file 3
U file 4
D file 3 (success)
D file 4 (failed)
U file 5
U file 6
U file 7
D file 7 (Success)
D file 6 (failed)
D file 5 (failed)

the order in which the files were uploaded doesn't matter. Only one out of consecutive file uploads can be deleted.

All files are being deleted from surf.properties but there is some stream which is using the ones that are failing and that's why surf isn't able to delete the failed ones from surf data. I am unable to figure out where exactly this unclosed stream is. Help would be appreciated.

[hangal]

@checker5965 delete dataset needs a confirm!
implemented

[checker5965]

@hangal the warning comes, but it still deletes the dataset. Is the confirmation only client-side? Even on selecting cancel, the dataset gets deleted.

[hangal]

thanks for reporting - fixed now.

[hangal]

If uploaded csv file has errors, we get this:

A simple CSV file like this causes this error:

ColName,ColName
1,1

[checker5965]

@hangal This is expected behaviour for csvParser because it maps column names to indices. If column names are not unique, it throws an error.