Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surf - Browser crash #62

Open
shivamgangwani opened this issue Oct 6, 2022 · 0 comments
Open

Surf - Browser crash #62

shivamgangwani opened this issue Oct 6, 2022 · 0 comments
Labels

Comments

@shivamgangwani
Copy link

Dataset used: Test_Tamil_Nadu.csv

To replicate the crash:

Settings used:
Column for IDs -> 'Candidate'
Columns to show during merge -> All
Within a cluster, sort by -> Year

Clustering algorithm -> Edit Distance
Maximum edit distance -> 2

Trying to open page 19 on the browser crashes surf.

My understanding is that Surf is throwing too much data at the browser (the clusters are massive, the ones that load have 100, 200-ish people in them), leading to the 'Aw snap' (Chrome error code 5).

Ideally,

  1. We should be able to set an upper limit on cluster sizes (so at most a cluster can have X people).
  2. The pagination logic should have an upper-bound on rows that it'll throw at the browser for a given page. Some preliminary exploration shows that right now, Surf throws 100 clusters per page, regardless of the sizes of these clusters. By setting an upper-bound on rows per page, the number of clusters per page will vary to conform to that limit.

Credits to @ananay95 for finding this edge case that leads to the crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant