Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors logged on startup in Electron 10 #767

Open
tomdixon opened this issue Nov 10, 2020 · 6 comments · May be fixed by #802
Open

Errors logged on startup in Electron 10 #767

tomdixon opened this issue Nov 10, 2020 · 6 comments · May be fixed by #802

Comments

@tomdixon
Copy link

Having recently upgraded from Electron 8 -> 10, I'm seeing console errors from the redux devtools extension on app startup. They appear to point to the use of the chrome.storage.sync API which seems to be unavailable in the Electron context.

The errors are:

Unchecked runtime.lastError: "sync" is not available in this instance of Chrome
Error handling response: TypeError: Cannot read property 'filter' of undefined
    at chrome-extension://lmhkpmbekcpmknklioeibfkpmmfibljd/js/content.bundle.js:1:21235

I'm using version 2.17.0 of the extension.

The extension does appear to work, so this isn't critical, but it'd be nice to get to the bottom of it, as the Electron docs claim that this extension should be compatible.

Any pointers would be much appreciated.
@funwithtriangles funwithtriangles mentioned this issue Nov 12, 2020
Open
@chetbox
Copy link

chetbox commented Nov 16, 2020

I'm seeing the same error in version 2.17.0 with Electron 10.1.5.

Screenshot from 2020-11-16 09-52-09

@ZainChen
Copy link

Also has this problem in electron 11.3.0.

@JiaoXin2005
Copy link

also appeared in electron 11.3.0 🙁

@matheusd matheusd mentioned this issue Apr 7, 2021
Merged
@none100p
Copy link

Also getting this one for 10.4.3

@Nantris
Copy link

Nantris commented Jun 4, 2021

Persists in Electron 11.4.x. Is this still maintained?

Nantris pushed a commit to Nantris/redux-devtools-extension that referenced this issue Jun 4, 2021
Wraps chrome.storage with try/catch
a5c1384 
Fixes zalmoxisus#767
@Nantris Nantris linked a pull request Jun 4, 2021 that will close this issue
Open
@Nantris
Copy link

Nantris commented Jun 4, 2021 •
edited

Just submitted #802 to resolve this, but I doubt this package is maintained so it's unlikely we'll see this merged.

Edit: Also, if anyone knows the correct typeof for chrome.storage.sync that we could check against, that would be cleaner than my current solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wraps chrome.storage with try/catch Nantris/redux-devtools-extension
6 participants
@chetbox @tomdixon @Nantris @ZainChen @JiaoXin2005 @none100p