-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use expression based properties #3947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in general okay with this change. Last decision lies by @rockfordlhotka
@SimonCropp Could you also please add this change to the editorconfig so it'll b suggested by VS automatically? Thanks
done |
@StefanOssendorf I'm good with this change - I like the language feature. Once your change request is satisfied it can be merged. |
@SimonCropp Please fix the conflicts |
Hi @SimonCropp Do you plan to continue working on this PR - to resolve the conflicts - or should I close it without merging? |
with that number of conflicts, it is prob easier to close this and resubmit |
No description provided.