Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use makeEnvironmentProviders function instead of config modules #19707

Merged
merged 16 commits into from
May 23, 2024
Merged

Use makeEnvironmentProviders function instead of config modules #19707

merged 16 commits into from
May 23, 2024

Conversation

Sinan997
Copy link
Contributor

@Sinan997 Sinan997 commented May 3, 2024 •
edited by masumulu28

Resolves #19715

@Sinan997 Sinan997 added this to the 8.3-preview milestone May 3, 2024
@Sinan997 Sinan997 requested a review from masumulu28 May 3, 2024 16:34
@Sinan997 Sinan997 marked this pull request as ready for review May 15, 2024 15:11
This was referenced May 15, 2024
Merged
Merged
@sumeyyeKurtulus sumeyyeKurtulus self-requested a review May 23, 2024 12:11
@masumulu28 masumulu28 merged commit 7a9d5e0 into dev May 23, 2024
2 of 3 checks passed
@masumulu28 masumulu28 deleted the sinan/environment-provider branch May 23, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masumulu28 masumulu28 masumulu28 approved these changes

@sumeyyeKurtulus sumeyyeKurtulus sumeyyeKurtulus approved these changes

Assignees
No one assigned
Labels
enhancement ui-angular
Projects
None yet
Milestone
8.3-preview
Development

Successfully merging this pull request may close these issues.

Convert class to provider function for modules
3 participants
@Sinan997 @masumulu28 @sumeyyeKurtulus