-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform-server): propagate errors from lifecycle hooks when utilizing platform-server #55787
base: main
Are you sure you want to change the base?
Conversation
81d2845
to
cdee9c8
Compare
f4be47b
to
88b383e
Compare
…izing platform-server In previous versions, if an error occurred within the lifecycle hooks, the promises for `renderModule` and `renderApplication` were not rejected. This could result in serving a "broken" page during Server-Side Rendering (SSR), or the build erroneously being marked as successful during Static Site Generation (SSG). Fixes angular#33642
88b383e
to
8a21cf8
Compare
Hey @alan-agius4,
I hope you don't mind that I added this comment directly to this PR. Best regards! |
Hi @alan-agius4 Did you consider making the The Analogically, we need the hook of "last moment" allowing to access DI and modify the final error (or returning a brand new error object - use case: return a custom "wrapper Error object" with the If you don't want to expose in the public API the whole |
In previous versions, if an error occurred within the lifecycle hooks, the promises for
renderModule
andrenderApplication
were not rejected. This could result in serving a "broken" page during Server-Side Rendering (SSR), or the build erroneously being marked as successful during Static Site Generation (SSG).Fixes #33642