Cleaner approach to generate _cocostuff_remap_info | Converted UnrecognizedYamlConfigEntry to Exception #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This results in more limited but more rpedictable results - Finished this TODO
…tuff_remap func - This is a cleaner but more maintainable way to generate _cocostuff_remap_info - This function still takes in consideration the skips which can be adjusted for future updates if needed - More readale and maintainable solution
jinyanzi
reviewed
May 28, 2024
- Updated and corrected cocostuff_skips Co-authored-by: yanzi <jinyanzi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner approach to generate _cocostuff_remap_info via generate_cocostuff_remap func
23d7d55ece289375ed9439351b409a56c1d2eb35
Converted UnrecognizedYamlConfigEntry to Exception
aad75846a197b39148269f702d1ce8c36e93b567