Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(s3-deployment): update development section of readme #30253

Merged
merged 5 commits into from
May 31, 2024

Conversation

neo01124
Copy link
Contributor

@neo01124 neo01124 commented May 17, 2024

…ent README

Reason for this change

The links in the development section of the aws-s3-deployment README are pointing to incorrect locations (files have been moved from those locations), fixed the links.

Description of changes

There are no code changes, only documentation update

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label May 17, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 17, 2024 09:07
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 17, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 17, 2024
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @neo01124! I think we can make it even clearer by calling out that the code in now in the custom-resource-handlers package. I think either in the link display text, or just "the code is now in the @aws-cdk/custom-resource-handlers package under ...".

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 20, 2024
@neo01124
Copy link
Contributor Author

sounds good, will add that

@scanlonp scanlonp changed the title docs(s3-deployment): update development section of the aws-s3-deploym… docs(s3-deployment): update development section of readme May 30, 2024
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finishing this up.

packages/aws-cdk-lib/aws-s3-deployment/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-s3-deployment/README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed scanlonp’s stale review May 30, 2024 20:12

Pull request has been modified.

scanlonp
scanlonp previously approved these changes May 30, 2024
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@mergify mergify bot dismissed scanlonp’s stale review May 30, 2024 20:14

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 30, 2024
Copy link
Contributor

mergify bot commented May 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 30, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6e83116
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4c3b6a0 into aws:main May 31, 2024
12 checks passed
Copy link
Contributor

mergify bot commented May 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants