-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor parser performance improvements for ts #16461
Open
liuxingbaoyu
wants to merge
19
commits into
babel:main
Choose a base branch
from
liuxingbaoyu:ts-parser-perf
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
added
pkg: parser
PR: Performance 🏃♀️
A type of pull request used for our changelog categories
labels
May 1, 2024
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57154 |
liuxingbaoyu
commented
May 1, 2024
@@ -260,6 +260,7 @@ function createWorker(useWorker) { | |||
return require("./babel-worker.cjs"); | |||
} | |||
const worker = new JestWorker(require.resolve("./babel-worker.cjs"), { | |||
enableWorkerThreads: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 0.3s faster on my local machine. :)
Comment on lines
+31
to
+42
copyFileSync( | ||
require.resolve("@babel-baseline/parser"), | ||
"./parser-baseline.cjs" | ||
); | ||
copyFileSync( | ||
"../../../packages/babel-parser/lib/index.js", | ||
"./parser-current.cjs" | ||
); | ||
|
||
const baseline = require("./parser-baseline.cjs"); | ||
const current = require("./parser-current.cjs"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
liuxingbaoyu
force-pushed
the
ts-parser-perf
branch
from
May 1, 2024 20:57
e35eb9e
to
8dd23f3
Compare
liuxingbaoyu
force-pushed
the
ts-parser-perf
branch
from
May 2, 2024 18:12
8dd23f3
to
2dbadd4
Compare
liuxingbaoyu
force-pushed
the
ts-parser-perf
branch
from
June 7, 2024 08:10
f5dce56
to
c479859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2
The performance improvement is only 1%-5%. :)