-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2605] Restrict collection access for some custom users #4096
Merged
+147
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4096 +/- ##
=======================================
Coverage 39.06% 39.07%
=======================================
Files 1201 1201
Lines 58010 58021 +11
Branches 5338 5339 +1
=======================================
+ Hits 22660 22670 +10
Misses 34295 34295
- Partials 1055 1056 +1 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
r-tome
approved these changes
May 17, 2024
shane-melton
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Currently, the Allow admin access to all collections and items setting does not affect Custom Users with the Manage Groups or Manage Users permissions - they can assign groups and users (respectively) to any collection, including those they don't manage.
Update their permission check to only allow this if Allow admin access is enabled. Otherwise, they must have Can Manage permissions like everyone else. This aligns them with how admins and owners are treated.
Clients PR: bitwarden/clients#9231
Code changes
Before you submit
dotnet format --verify-no-changes
) (required)