fix: Right click Snooze is not working #9498
Conversation
app/javascript/dashboard/routes/dashboard/commands/commandbar.vue
Outdated
Show resolved
Hide resolved
| @@ -143,12 +128,10 @@ export default { | |||
| }, | |||
| }, | |||
| mounted() { | |||
| bus.$on(CMD_SNOOZE_CONVERSATION, this.onCmdSnoozeConversation); | |||
There was a problem hiding this comment.
I moved the CMD_SNOOZE_CONVERSATION bus event from the ResolveAction.vue to the ChatList.vue so that the same event could be used from the chat list and chat view.
| @@ -15,6 +15,7 @@ const state = { | |||
| currentInbox: null, | |||
| selectedChatId: null, | |||
| appliedFilters: [], | |||
| contextMenuChatId: null, | |||
There was a problem hiding this comment.
I use Vuex to show the snooze option dynamically on the CMD bar. Only show the snooze option in the CMD bar when we click the snooze button from the context menu (NB: home route)
| @@ -67,7 +67,7 @@ | |||
| "markdown-it": "^13.0.2", | |||
| "markdown-it-link-attributes": "^4.0.1", | |||
| "md5": "^2.3.0", | |||
| "ninja-keys": "^1.2.2", | |||
There was a problem hiding this comment.
Any particular reason to use a fork of ninja-keys?
There was a problem hiding this comment.
@scmmishra Yes, the ninja-keys don't support the close event. So @muhsin-k has created a PR in the official repo, which is not merged as I guess it is not maintained. The changes in the PR are updated in our forked repo and deployed in npm by Muhsin.
app/javascript/dashboard/components/widgets/conversation/contextMenu/Index.vue
Outdated
Show resolved
Hide resolved
Pull Request Template
Description
This PR will fix the snooze action that is not working on the right click
Fixes https://linear.app/chatwoot/issue/CW-3313/right-click-snooze-is-not-working
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Loom video
https://www.loom.com/share/db9c62931a5d4836b37354bdae1a61db?sid=4ddf1467-2132-4e1c-a88b-d0cea0234c67
Checklist: