Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13012: fix loading with non-ascii symbols in path #14883

Merged
merged 1 commit into from
May 26, 2024

Conversation

strkkk
Copy link
Member

@strkkk strkkk commented May 18, 2024

Closes #13012

Attempt number 3 to fix this issue

@strkkk strkkk force-pushed the 13012_use_ascii branch 3 times, most recently from 1c70977 to bb020ec Compare May 18, 2024 13:58
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only point to improve

@romani romani self-assigned this May 19, 2024
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani requested a review from nrmancuso May 21, 2024 15:23
@romani romani assigned nrmancuso and unassigned romani May 21, 2024
Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nrmancuso nrmancuso merged commit 8a4b406 into checkstyle:master May 26, 2024
112 checks passed
@strkkk strkkk deleted the 13012_use_ascii branch May 26, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkstyle fails with "Path contains invalid character" if path to config file contains non-ascii characters
3 participants