-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvpb: remove deprecated fields from BulkOpSummary #124389
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
These fields aren't actually used and haven't been for several years now. Epic: None Release note: None
45ae891
to
5a3f320
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this cleanup.
TFTR! bors r+ |
124389: kvpb: remove deprecated fields from BulkOpSummary r=yuzefovich a=yuzefovich These fields aren't actually used and haven't been for several years now. Epic: None Release note: None 124865: acceptance: use `docker compose` r=rickystewart a=rail Previously, we used `docker-compose` (V1) to run acceptance tests. `docker compose` is a plugin now and not a separate command, which supports V2 compose files. See https://docs.docker.com/compose/migrate/#what-are-the-differences-between-compose-v1-and-compose-v2 for the details. Epic: none Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Rail Aliiev <rail@iqchoice.com>
Build failed (retrying...): |
bors r+ |
Already running a review |
124389: kvpb: remove deprecated fields from BulkOpSummary r=yuzefovich a=yuzefovich These fields aren't actually used and haven't been for several years now. Epic: None Release note: None 124681: sql: add information about which KV nodes served read requests r=rickystewart a=yuzefovich This PR exposes information in EXPLAIN ANALYZE output about which KV nodes participated in evaluating read requests. See each commit for details. Fixes: #91774. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build failed (retrying...): |
These fields aren't actually used and haven't been for several years now.
Epic: None
Release note: None