Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: mixedversion: split cockroach addressing into services #124408

Merged

Conversation

renatolabs
Copy link
Collaborator

Backport 1/1 commits from #123680 and 1/1 commits from #124199.

/cc @cockroachdb/release


This commit introduces the notion of services to the mixedversion framework. Previously, callers would reference a server by a node in the cluster. However, we want to move to a direction where there might be multiple services running in the cluster (i.e., not only the system tenant, but application tenant(s) as well). The service abstraction allows callers to perform operations either on the service that is serving application requests or directly on the system tenant.

The framework exposes the test's "default service". This represents the service that is responsible for handling application requests in a test. For traditional, non-UA deployments, this is the system tenant as usual. For UA deployments (not yet implemented), this will point to a tenant service created during test setup.

This reorganization should have no observable behavioural change for tests. However, it lays the foundation on which UA deployments will be implemented in the framework.

Epic: none

Release note: None


Release justification: test only changes.

This commit introduces the notion of `services` to the mixedversion
framework. Previously, callers would reference a server by a node in
the cluster. However, we want to move to a direction where there might
be multiple services running in the cluster (i.e., not only the system
tenant, but application tenant(s) as well). The service abstraction
allows callers to perform operations either on the service that is
serving application requests or directly on the system tenant.

The framework exposes the test's "default service". This represents
the service that is responsible for handling application requests in a
test. For traditional, non-UA deployments, this is the system tenant
as usual. For UA deployments (not yet implemented), this will point to
a tenant service created during test setup.

This reorganization should have no observable behavioural change for
tests. However, it lays the foundation on which UA deployments will be
implemented in the framework.

Epic: none

Release note: None
Small bug introduced by the changes in cockroachdb#123134.

Epic: none

Release note: None
@renatolabs renatolabs requested a review from a team as a code owner May 20, 2024 06:15
@renatolabs renatolabs requested review from nameisbhaskar and vidit-bhat and removed request for a team May 20, 2024 06:15
Copy link

blathers-crl bot commented May 20, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 20, 2024
Copy link

blathers-crl bot commented May 20, 2024

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@renatolabs
Copy link
Collaborator Author

Mixed-version tests pass on this branch.

@renatolabs
Copy link
Collaborator Author

TFTR!

@renatolabs renatolabs merged commit 0cf3fc7 into cockroachdb:release-24.1 May 21, 2024
19 of 20 checks passed
@renatolabs renatolabs deleted the rc/backport-123134-124199-24.1 branch May 21, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants