roachprod: add custom tags for prometheus config #124409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameisbhaskar
requested review from
renatolabs and
vidit-bhat
and removed request for
a team
|
This change is |
nameisbhaskar
force-pushed
the
user/bhaskar/add-custom-labels
branch
2 times, most recently
from
2011803
to
0fc302a
Compare
srosenberg
reviewed
May 21, 2024
srosenberg
reviewed
May 21, 2024
srosenberg
reviewed
May 21, 2024
srosenberg
reviewed
May 21, 2024
srosenberg
approved these changes
May 21, 2024
few of the labels are missing in prometheus with the change from "gce_sd_configs" to "file_sd_configs". This is because these were extracted from the VM metadata which is not available now. So, the same values are set from roachprod now. Informs: cockroachdb#124319 Epic: none
nameisbhaskar
force-pushed
the
user/bhaskar/add-custom-labels
branch
from
0fc302a
to
9e30f6f
Compare
|
Thanks @srosenberg for reviewing this!! |
|
bors r=@srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
few of the labels are missing in prometheus with the change from "gce_sd_configs" to "file_sd_configs". This is because these were extracted from the VM metadata which is not available now. So, the same values are set from roachprod now.
Informs: #124319
Epic: none