Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know that visit a
KtFile
is not free at all. But we don't have any values to see if this is really faster or not.My next project on detekt is going to be a tool to monitor the detekt performance. Once we have that we could take a look at the
Rule
implementation because I think that it pushes to overuse thevisit
pattern everywhere even in cases that is not needed (for example the one of this PR)I left this PR as draft because I want to know how much faster is
InvalidPackageDeclaration
with this change.