Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Message): properly compare attachments and embeds #10282

Merged

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This properly compares attachments and embeds properties instead of just comparing the lengths.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@sdanialraza sdanialraza requested a review from a team as a code owner May 18, 2024 08:27
Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 2:15pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 2:15pm

packages/discord.js/src/structures/Message.js Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit a468ae8 into discordjs:main May 24, 2024
6 checks passed
@sdanialraza sdanialraza deleted the fix/properly-compare-attachments-embeds branch May 24, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants