-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test InputDecoration API examples #148560
base: master
Are you sure you want to change the base?
Test InputDecoration API examples #148560
Conversation
@NobodyForNothing thanks for contributing! It looks like there are some failing checks, can you take a look? |
985a8b8
to
e16bf85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests collection!
examples/api/test/material/input_decorator/input_decoration.1_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/material/input_decorator/input_decoration.2_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/material/input_decorator/input_decoration.3_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/material/input_decorator/input_decoration.label.0_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/material/input_decorator/input_decoration.prefix_icon_constraints.0_test.dart
Outdated
Show resolved
Hide resolved
examples/api/test/material/input_decorator/input_decoration.suffix_icon_constraints.0_test.dart
Outdated
Show resolved
Hide resolved
greaterThan(tester.getSize(smallerIcon).longestSide)); | ||
}); | ||
|
||
testWidgets('Is suffix icon', (WidgetTester tester) async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testWidgets('Is suffix icon', (WidgetTester tester) async { | |
testWidgets('Is suffix icon', (WidgetTester tester) async { |
Not sure what this means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the description to suffixIcons are placed right of hintText
. The goal of this text is to ensure the icon in the example is actually a suffix icon (after content) and not a prefix icon.
While this is not the main point the example is trying to illustrate, I believe it is necessary to differentiate between the prefixIconConstraints and the suffixIconConstraints example.
Add tests for
InputDecoration
API example as part of #130459. Updates examples that use the deprecated MaterialState to use WidgetState. Tests files:input_decoration.0.dart
,input_decoration.1.dart
,input_decoration.2.dart
,input_decoration.3.dart
,input_decoration.widget_state.0.dart
,input_decoration.widget_state.1.dart
,input_decoration.prefix_icon_constraints.0.dart
,input_decoration.suffix_icon_constraints.0.dart
, andinput_decoration.label.0.dart
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.