enhancement: add MaskedInput icon click-ability #7066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces the ability to make the MaskedInput icon clickable, triggering the display of suggestion options.
Where should the reviewer start?
Review changes in the MaskedInput component related to icon click-ability(components/MaskedInput/MaskedInput.js).
What testing has been done on this PR?
How should this be manually tested?
Manually test by clicking the icon in a MaskedInput field with the
maskIconClickable
prop set totrue
and verify the suggestion options appear. Then, test withmaskIconClickable
set tofalse
and ensure the icon does not trigger the suggestions.Do Jest tests follow these best practices?
screen
is used for querying.asFragment()
is used for snapshot testing.Any background context you want to provide?
This enhancement improves user interaction with MaskedInput by allowing suggestions to be triggered by clicking the icon.
What are the relevant issues?
fixes: #7042
Screen-record (if appropriate)
Screen.Recording.2023-12-14.at.2.06.43.AM.mov
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Not sure.
Is this change backwards compatible or is it a breaking change?
No.