Suggestion: Remove package-lock.json from .gitignore files #615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thanks for the great work on MAL! I've just started working through it and am really enjoying it so far. Something I found odd however is that
package-lock.json
appears in a few.gitignore
files. Was this intentional?AFAIK
package-lock.json
file is intended to be checked in to source control in order to make builds reproducible; without apackage-lock.json
filenpm install
becomes non-deterministic.See e.g. https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json:
As such, this PR removes
package-lock.json
from the.gitignore
files in root andimpls