-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intial translation of the figures for the chapters of backtracking, divide and conquer, appendix #1337
Conversation
…g, divide and conquer, appendix
Please review the translation based on the following aspects:
In addition to content, please pay attention to the format:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good to me.
there is one part that the bold and black text difference is a bit hard to be determined because of the style of text. and there is mismatch in colors in some other ones.
en/docs/chapter_backtracking/backtracking_algorithm.assets/preorder_find_constrained_paths.png
Outdated
Show resolved
Hide resolved
en/docs/chapter_backtracking/n_queens_problem.assets/n_queens_constraints.png
Show resolved
Hide resolved
en/docs/chapter_backtracking/n_queens_problem.assets/n_queens_placing.png
Outdated
Show resolved
Hide resolved
en/docs/chapter_backtracking/permutations_problem.assets/permutations_i_pruning.png
Show resolved
Hide resolved
en/docs/chapter_backtracking/permutations_problem.assets/permutations_i.png
Outdated
Show resolved
Hide resolved
en/docs/chapter_backtracking/permutations_problem.assets/permutations_ii_pruning.png
Show resolved
Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_i_pruning.png
Show resolved
Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_ii.png
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure if its just me, the color grey and black is a bit hard to be determined compared to the text style from cn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
”Subproblem f(1): ... to C“ -> ”Move remaining 1 disk from A to C“
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
”Subproblem f(1): ... to C“ -> ”Move remaining 1 disk from A to C“
No space for this 🤣
en/docs/chapter_divide_and_conquer/hanota_problem.assets/hanota_f3_step1.png
Show resolved
Hide resolved
en/docs/chapter_backtracking/permutations_problem.assets/permutations_i_pruning.png
Show resolved
Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_i_pruning.png
Show resolved
Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_ii.png
Show resolved
Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_ii.png
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
”Subproblem f(1): ... to C“ -> ”Move remaining 1 disk from A to C“
en/docs/chapter_divide_and_conquer/hanota_problem.assets/hanota_f3_step1.png
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be better to replace "with" with a comma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Record solution, then continue searching without returning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some wording and styling issues, but amazing work! Please consider my suggestions.
Thanks for your thorough review! @K3v123, @pengchzn, @yuelinxin, most of the comments have been addressed. A few comments remain unresolved for further discussion. Please let me know if there's anything else that needs fixing. |
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below: