Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/kube-vip-cloud-provider-autodeploy #11005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrxmvtik
Copy link
Contributor

@chrxmvtik chrxmvtik commented Mar 12, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Kube VIP addon contains a setting that let us load-balance services (kube_vip_services_enabled: true), however to make it work, we need to deploy Kube VIP Cloud Provider manually when cluster is deployed.

In order to make this ready in the out of the box manner, I've added a possibility to deploy Cloud Provider that will include all required settings (just one variable actually).

It doesn't cost us much space and trouble, but makes more sense related to service loadbalancing setting that can be set like right now.

Does this PR introduce a user-facing change?:

User have possibility to set two new settings in addons (Line 263):

# Kube VIP Cloud Provider
kube_vip_cloud_provider_enabled: false
# Define your own IP Pools or leave empty {}
kube_vip_cloud_provider_ip_pools:
  cidr-global: 172.16.0.0/24
  cidr-default: 192.168.0.200/30,192.168.0.200/29
  range-development: 192.168.0.210-192.168.0.220
  cidr-ipv6: 2001::10/127

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chrxmvtik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrxmvtik
Once this PR has been reviewed and has the lgtm label, please assign cristicalin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

updated readme

fix lint errors
@yankay
Copy link
Member

yankay commented Mar 14, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2024
@tuxillo
Copy link

tuxillo commented Apr 4, 2024

Nice addition! Will you be able to apply it for already deployed clusters?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants