-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/kube-vip-cloud-provider-autodeploy #11005
base: master
Are you sure you want to change the base?
Conversation
Hi @chrxmvtik. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chrxmvtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
updated readme fix lint errors
/ok-to-test |
Nice addition! Will you be able to apply it for already deployed clusters? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Kube VIP addon contains a setting that let us load-balance services (kube_vip_services_enabled: true), however to make it work, we need to deploy Kube VIP Cloud Provider manually when cluster is deployed.
In order to make this ready in the out of the box manner, I've added a possibility to deploy Cloud Provider that will include all required settings (just one variable actually).
It doesn't cost us much space and trouble, but makes more sense related to service loadbalancing setting that can be set like right now.
Does this PR introduce a user-facing change?: