-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JS layout adjustment and rely on CSS #21226
base: 5.x-dev
Are you sure you want to change the base?
Conversation
The JS was updated in 2015 via c1f3328 with the commit message "in admin area make sure to use as much content width as possible", so I guess the purpose was to stretch out the main content area. The code was there already even before git times by the looks. Are we possibly losing that by removing this whole file or has the UI or how it's currently done superseded for all widgets/views/whatever it may affect? |
76fc860
to
87544cd
Compare
The CSS handles it most cases, I did add another commit add 100% width now it seems to work consistently. |
@@ -1,4 +1,8 @@ | |||
|
|||
.admin { | |||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using global classes is always a bit "risky". This specific class would e.g. also apply here:
<div id="feedback-faq" class="admin"> |
It doesn't hurt in this case, as it doesn't have an effect, but might also be possible that a plugin might use that class for anything.
As it should only effect the admin content page, it might be better placed here:
matomo/plugins/CoreHome/stylesheets/coreHome.less
Lines 23 to 30 in d13d4c4
#content.admin { | |
display: inline-block; | |
max-width: 1300px; | |
> .row { | |
margin: 0 -0.75rem; | |
} | |
} |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
I think if we get #21689 over the line we might be able to close this. |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
Description:
Fixes #21224
The JS calculation of width seemed to break layout in Safari from the admin screen.
Review