-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix milestone reminder #42861
Fix milestone reminder #42861
Conversation
// Exit as soon as we found an issue without a milestone and alerted the author. | ||
process.exit(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iethree as the alternative, we can let the script go through ALL linked issues and alert for each issue without a milestone individually. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think one message is sufficient, i like how you did it here 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love these ❤️
// Exit as soon as we found an issue without a milestone and alerted the author. | ||
process.exit(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think one message is sufficient, i like how you did it here 👍
@nemanjaglumac Did you forget to add a milestone to the issue #42835 linked in this PR? When and where should I add a milestone? |
Description
Resolves #42835.
The milestone reminder workflow has been broken.
My previous attempt to fix it didn't really work because the parsing logic was wrong.
This is the example:
https://github.com/metabase/metabase/actions/runs/9382661958/job/25834555041#step:2:78
Notice how it tries to fetch
https://api.github.com/repos/metabase/metabase/issues/s
Some local experimentation explains why this happened in the past:
I've now included a lot of unit tests to make sure this script is working.
Notable Changes
How to verify
Checklist