[3.x] Fix error log create cmd #13145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v3-migration-docs canceled.
|
✅ Deploy Preview for v3-meteor-api-docs canceled.
|
nachocodoner
changed the title
StorytellerCZ
approved these changes
May 15, 2024
denihs
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS-409
Issue
Context: #13106
Several developers reported issues with failures when using Meteor create. I followed further research into the issue.
Initially, I thought it was caused by the new machinery introduced in this PR to prepare the template projects fetching from github using
git clonecommand.The reported errors, such as "Will use cached version of skeletons" and "Something has happened while creating your app using git clone", correspond to a specific part of the code.. However, it turns out that these errors occur consistently when the --release option is used, with the message "Error message: Using release option" always present. This error is unrelated to network connectivity and is, in fact, a false alarm.
In the following image, you can see how the false error appears, yet the meteor create command continues to execute, fetching packages remotely to set up your new app. The errors manifest afterwards this.
Occasionally, this process triggers timeouts for developers with unstable internet connections, leading to errors like
ECONNRESETandENETUNREACH, typically corresponding of client-side issues. However, we will pay more attention, we can't confirm 100% that is not a problem in Meteor side, but we need clear reproduction steps to follow.As part of this pull request we have indeed fixed the false error.