-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ct): resolve hooksConfig import refs #30455
Conversation
This comment has been minimized.
This comment has been minimized.
9a15f00
to
3018962
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
fafa376
to
cee7600
Compare
This comment has been minimized.
This comment has been minimized.
cee7600
to
81bca97
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 flaky27248 passed, 671 skipped Merge workflow run. |
👋 @sand4rt 👋 taking care of our review debt. is this something you'd like me to look at? |
👋 @pavelfeldman, yes please. Let me know if more info is needed |
Tried reviewing it and failed - sounds like too many things are happening at a time. Any chance for it to be split in chunks? Also spotted a declare module there, we have general distaste to those, we like types to chain / infer explicitly instead. |
@pavelfeldman Sure, no problem. I split the first part in #31024. Will do the second part later on because they depend on eachother. I also usually distaste |
closes #30453 and #19933