Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use python3 instead of python in pummel test #53057

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fahrradflucht
Copy link
Contributor

@fahrradflucht fahrradflucht commented May 19, 2024

Just a small test change I found myself floating on main:

As f9bfe78 already did for a regular test, replace python with python3 in the only pummel test spawning it so that it can be run on platforms that don't provide a python binary anymore, like modern macOS or some Linux distributions (e.g. Fedora) without specifying a PYTHON env var.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 19, 2024
@VoltrexKeyva
Copy link
Member

VoltrexKeyva commented May 19, 2024

Change ptyhon3 to python3 in commit message.

As f9bfe78 already did for a regular test, replace `python` with
`python3` in the only `pummel` test spawning it so that it can be run on
platforms that don't provide a `python` binary anymore, like modern
macOS or some Linux distributions (e.g. Fedora) without specifying a
`PYTHON` env var.
@fahrradflucht fahrradflucht force-pushed the test-switch-to-python3-in-pummel branch from c9b6fb5 to b395a10 Compare May 20, 2024 06:02
@fahrradflucht

This comment was marked as resolved.

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 31, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants